[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque optio
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options |
Date: |
Fri, 05 Oct 2012 12:51:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/05/2012 12:44 PM, Corey Bryant wrote:
> Yes, this makes more sense. I'd like to mirror the add-fd QMP command
> as much as possible:
>
> { 'command': 'add-fd', 'data': {'*fdset-id': 'int', '*opaque': 'str'},
> 'returns': 'AddfdInfo' }
>
> So maybe we can make it:
>
> -add-fd fd=24,fdset-id=1,opaque="rdonly" -add-fd
> fd=25,fdset-id=1,opaque="rdwr"
Sounds better. Note that while fdset-id is optional in QMP, I think it
needs to be mandatory on the CLI (you're telling qemu to use an
inherited fd, but unless you know what set that fd belongs to, you can't
then refer to that fd elsewhere on the command line, and unlike the QMP
command, there is no venue for QMP to tell you what set was autocreated).
Bike-shedding: I think the command line can be slightly shorter with:
-add-fd fd=24,set=1,opaque=...
with no real loss in information (that is, s/fdset-id/set/), since our
command lines are already quite long. But going longhand to match QMP
doesn't hurt my feelings (libvirt will be automating this all anyway, so
I won't really be typing it by hand).
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 2/4] monitor: Enable adding an inherited fd to an fd set, Corey Bryant, 2012/10/05
[Qemu-devel] [PATCH 4/4] blockdev: Process -drive fd and opaque options, Corey Bryant, 2012/10/05
[Qemu-devel] [PATCH 1/4] monitor: Less restrictive fd matching for fd sets, Corey Bryant, 2012/10/05
Re: [Qemu-devel] [PATCH 0/4] command line fd passing using fd sets, Eric Blake, 2012/10/05