[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU PATCH] create struct for machine initialization a
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [QEMU PATCH] create struct for machine initialization arguments |
Date: |
Fri, 5 Oct 2012 17:09:53 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Oct 05, 2012 at 03:37:00PM -0300, Eduardo Habkost wrote:
[...]
> diff --git a/hw/boards.h b/hw/boards.h
> index a2e0a54..813d0e5 100644
> --- a/hw/boards.h
> +++ b/hw/boards.h
> @@ -5,12 +5,16 @@
>
> #include "qdev.h"
>
> -typedef void QEMUMachineInitFunc(ram_addr_t ram_size,
> - const char *boot_device,
> - const char *kernel_filename,
> - const char *kernel_cmdline,
> - const char *initrd_filename,
> - const char *cpu_model);
> +typedef struct QEMUMachineInitArgs {
> + ram_addr_t ram_size;
> + const char *boot_device;
> + const char *kernel_filename;
> + const char *kernel_cmdline;
> + const char *initrd_filename;
> + const char *cpu_model;
> +} QEMUMachineInitArgs;
> +
> +typedef void QEMUMachineInitFunc(QEMUMachineInitArgs *args);
>
> typedef void QEMUMachineResetFunc(void);
>
[...]
> @@ -332,7 +335,8 @@ static void pc_init_isa(ram_addr_t ram_size,
> }
>
> #ifdef CONFIG_XEN
> -static void pc_xen_hvm_init(ram_addr_t ram_size,
> +static void pc_xen_hvm_init(QEMUMachine *machine,
> + ram_addr_t ram_size,
Oops. This is a leftover of an idea on which I was working previously
(and then abandoned). It's obviously broken.
I will submit a fixed version.
--
Eduardo