[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/8] hw/qxl: exit on failure to register qxl interfa
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 4/8] hw/qxl: exit on failure to register qxl interface |
Date: |
Mon, 8 Oct 2012 12:49:47 +0200 |
From: Alon Levy <address@hidden>
This prevents a segfault later on when the device reset handler
tries to access a NULL ssd.worker since interface_attach_worker has
not been called.
Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/qxl.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index eb7707c..e99ed55 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -2037,7 +2037,11 @@ static int qxl_init_common(PCIQXLDevice *qxl)
qxl->ssd.qxl.base.sif = &qxl_interface.base;
qxl->ssd.qxl.id = qxl->id;
- qemu_spice_add_interface(&qxl->ssd.qxl.base);
+ if (qemu_spice_add_interface(&qxl->ssd.qxl.base) != 0) {
+ error_report("qxl interface %d.%d not supported by spice-server\n",
+ SPICE_INTERFACE_QXL_MAJOR, SPICE_INTERFACE_QXL_MINOR);
+ return -1;
+ }
qemu_add_vm_change_state_handler(qxl_vm_change_state_handler, qxl);
init_pipe_signaling(qxl);
--
1.7.1
- [Qemu-devel] [PULL 0/8] spice patch queue, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 3/8] qxl: fix range check for rev3 io commands., Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 8/8] qxl: set default revision to 4, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 6/8] hw/qxl: qxl_dirty_surfaces: use uintptr_t, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 7/8] spice: raise requirement to 0.12, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 1/8] qxl: always update displaysurface on resize, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 5/8] hw/qxl: fix condition for exiting guest_bug, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 2/8] qxl/update_area_io: cleanup invalid parameters handling, Gerd Hoffmann, 2012/10/08
- [Qemu-devel] [PATCH 4/8] hw/qxl: exit on failure to register qxl interface,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PULL 0/8] spice patch queue, Anthony Liguori, 2012/10/12