[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 16/21] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_E
From: |
Jason Baron |
Subject: |
[Qemu-devel] [PATCH v2 16/21] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask |
Date: |
Mon, 8 Oct 2012 23:30:36 -0400 |
From: Jan Kiszka <address@hidden>
Both bits are added to the write-1-to-clear mask by default. As the
smbus device does not allow writes at all, we have to remove it from
that mask, also to avoid triggering a runtime assertion.
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Jason Baron <address@hidden>
---
hw/q35_smbus.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/q35_smbus.c b/hw/q35_smbus.c
index 5efbe6c..dd64aa2 100644
--- a/hw/q35_smbus.c
+++ b/hw/q35_smbus.c
@@ -97,6 +97,10 @@ static int ich9_smbus_initfn(PCIDevice *d)
pci_set_word(d->wmask + PCI_STATUS,
PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY);
+ pci_set_word(d->w1cmask + PCI_STATUS,
+ pci_get_word(d->w1cmask + PCI_STATUS) &
+ ~(PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY));
+
/* TODO? D31IP.SMIP in chipset configuration space */
pci_config_set_interrupt_pin(d->config, 0x01); /* interrupt pin 1 */
--
1.7.1
- [Qemu-devel] [PATCH v2 07/21] pc/piix_pci: factor out smram/pam logic, (continued)
- [Qemu-devel] [PATCH v2 07/21] pc/piix_pci: factor out smram/pam logic, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 14/21] q35: Suppress SMM BIOS initialization under KVM, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 17/21] q35: Add kvmclock support, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 15/21] q35: Fix non-PCI IRQ processing in ich9_lpc_update_apic, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 19/21] Add a fallback bios file search, if -L fails., Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 16/21] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask,
Jason Baron <=
- [Qemu-devel] [PATCH v2 18/21] q35: Fix irr initialization for slots 25..31, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 12/21] q35: Introduce q35 pc based chipset emulator, Jason Baron, 2012/10/08
- [Qemu-devel] [PATCH v2 20/21] q35: automatically load the q35 dsdt table, Jason Baron, 2012/10/08