[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 02/13] tcg-sparc: Fix brcond2
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 02/13] tcg-sparc: Fix brcond2 |
Date: |
Wed, 10 Oct 2012 09:02:36 -0700 |
Much the same problem as recently fixed for hppa.
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/sparc/tcg-target.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c
index 0c32baa..2475808 100644
--- a/tcg/sparc/tcg-target.c
+++ b/tcg/sparc/tcg-target.c
@@ -561,33 +561,24 @@ static void tcg_out_brcond2_i32(TCGContext *s, TCGCond
cond,
/* Note that we fill one of the delay slots with the second compare. */
switch (cond) {
case TCG_COND_EQ:
- cc = INSN_COND(tcg_cond_to_bcond[TCG_COND_NE], 0);
- tcg_out_branch_i32(s, cc, label_next);
+ tcg_out_branch_i32(s, COND_NE, label_next);
tcg_out_cmp(s, al, bl, blconst);
- cc = INSN_COND(tcg_cond_to_bcond[TCG_COND_EQ], 0);
- tcg_out_branch_i32(s, cc, label_dest);
+ tcg_out_branch_i32(s, COND_E, label_dest);
break;
case TCG_COND_NE:
- cc = INSN_COND(tcg_cond_to_bcond[TCG_COND_NE], 0);
- tcg_out_branch_i32(s, cc, label_dest);
+ tcg_out_branch_i32(s, COND_NE, label_dest);
tcg_out_cmp(s, al, bl, blconst);
- tcg_out_branch_i32(s, cc, label_dest);
+ tcg_out_branch_i32(s, COND_NE, label_dest);
break;
default:
- /* ??? One could fairly easily special-case 64-bit unsigned
- compares against 32-bit zero-extended constants. For instance,
- we know that (unsigned)AH < 0 is false and need not emit it.
- Similarly, (unsigned)AH > 0 being true implies AH != 0, so the
- second branch will never be taken. */
- cc = INSN_COND(tcg_cond_to_bcond[cond], 0);
+ cc = tcg_cond_to_bcond[tcg_high_cond(cond)];
tcg_out_branch_i32(s, cc, label_dest);
tcg_out_nop(s);
- cc = INSN_COND(tcg_cond_to_bcond[TCG_COND_NE], 0);
- tcg_out_branch_i32(s, cc, label_next);
+ tcg_out_branch_i32(s, COND_NE, label_next);
tcg_out_cmp(s, al, bl, blconst);
- cc = INSN_COND(tcg_cond_to_bcond[tcg_unsigned_cond(cond)], 0);
+ cc = tcg_cond_to_bcond[tcg_unsigned_cond(cond)];
tcg_out_branch_i32(s, cc, label_dest);
break;
}
--
1.7.11.4
- [Qemu-devel] [PATCH v2 00/13] tcg-sparc fixes and improvements, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 01/13] target-sparc: Fix optimized %icc comparisons, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 02/13] tcg-sparc: Fix brcond2,
Richard Henderson <=
- [Qemu-devel] [PATCH 03/13] tcg-sparc: Implement movcond., Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 11/13] tcg-sparc: Dump illegal opode contents, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 05/13] tcg-sparc: Fix qemu_st for 32-bit, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 07/13] tcg-sparc: Fix add2/sub2, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 04/13] tcg-sparc: Fix setcond2, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 13/13] tcg-sparc: Emit MOVR insns for setcond_i64 and movcond_64, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 09/13] tcg-sparc: Optimize setcond2 equality compare with 0., Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 08/13] tcg-sparc: Use Z constraint for %g0, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 12/13] tcg-sparc: Emit BPr insns for brcond_i64, Richard Henderson, 2012/10/10
- [Qemu-devel] [PATCH 06/13] tcg-sparc: Fix setcond, Richard Henderson, 2012/10/10