[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] block: in commit, determine base image from
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] block: in commit, determine base image from the top image |
Date: |
Thu, 11 Oct 2012 09:36:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/09/2012 11:56 PM, Jeff Cody wrote:
> This simplifies some code and error checking, and also fixes a bug.
>
> bdrv_find_backing_image() should only be passed absolute filenames,
> or filenames relative to the chain. In the QMP message handler for
> block commit, when looking up the base do so from the determined top
> image, so we know it is reachable from top.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> +++ b/blockdev.c
> @@ -1182,6 +1172,17 @@ void qmp_block_commit(const char *device,
> return;
> }
>
> + if (base && has_base) {
Code motion, but won't this order trigger valgrind warnings about
jumping based on a read of uninitialized memory? That is, the canonical
ordering is 'has_base && base' (although the end result is the same,
with the difference only observable in valgrind).
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_find_backing_image compare canonical filenames, (continued)
Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_find_backing_image compare canonical filenames, Eric Blake, 2012/10/10
[Qemu-devel] [PATCH 2/2] block: in commit, determine base image from the top image, Jeff Cody, 2012/10/10