|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support. |
Date: | Fri, 12 Oct 2012 12:50:19 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
Il 12/10/2012 12:23, Gerd Hoffmann ha scritto: >> I suggest that you implement the commands in a similar way as netdev_add. > > Why? Isn't the whole point of using josn is that you'll get the stuff > from the josn parser & marshaller in a usable form instead of having it > to feed into yet another parser? I think the only reason netdev_add > exists in the current form is that it predates qmp. In principle you're right, but I think it's ugly that adding another chardev argument needs changes in 3 places instead of just one. (And I'd like to add another argument soon enough...). Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |