[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/41] ram: Export last_ram_offset()
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 11/41] ram: Export last_ram_offset() |
Date: |
Fri, 12 Oct 2012 12:43:04 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Juan Quintela <address@hidden> writes:
> Is the only way of knowing the RAM size.
>
> Signed-off-by: Juan Quintela <address@hidden>
>
> Reviewed-by: Paolo Bonzini <address@hidden>
> ---
> cpu-all.h | 2 ++
> exec.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/cpu-all.h b/cpu-all.h
> index 74d3681..5408782 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -517,6 +517,8 @@ extern int mem_prealloc;
> void dump_exec_info(FILE *f, fprintf_function cpu_fprintf);
> #endif /* !CONFIG_USER_ONLY */
>
> +ram_addr_t last_ram_offset(void);
> +
> int cpu_memory_rw_debug(CPUArchState *env, target_ulong addr,
> uint8_t *buf, int len, int is_write);
cpu-all.h is included by linux-user and ram_addr_t isn't available when
!CONFIG_USER_ONLY.
This breaks the build which also implies this series has only been
tested with a restricted target list.
Please make sure you don't submit pull requests without *at least* doing
a full build and 'make check'.
Regards,
Anthony Liguori
>
> diff --git a/exec.c b/exec.c
> index bb6aa4a..e613329 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2462,7 +2462,7 @@ static ram_addr_t find_ram_offset(ram_addr_t size)
> return offset;
> }
>
> -static ram_addr_t last_ram_offset(void)
> +ram_addr_t last_ram_offset(void)
> {
> RAMBlock *block;
> ram_addr_t last = 0;
> --
> 1.7.11.4
- Re: [Qemu-devel] [PATCH 02/41] fix migration sync, (continued)
- [Qemu-devel] [PATCH 03/41] migration: store end_time in a local variable, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 04/41] migration: print total downtime for final phase of migration, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 05/41] migration: rename expected_time to expected_downtime, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 07/41] migration: print expected downtime in info migrate, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 08/41] savevm: Factorize ram globals reset in its own function, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 14/41] Separate migration bitmap, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 09/41] ram: introduce migration_bitmap_set_dirty(), Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 11/41] ram: Export last_ram_offset(), Juan Quintela, 2012/10/02
- Re: [Qemu-devel] [PATCH 11/41] ram: Export last_ram_offset(),
Anthony Liguori <=
- [Qemu-devel] [PATCH 06/41] migration: export migrate_get_current(), Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 10/41] ram: Introduce migration_bitmap_test_and_reset_dirty(), Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 12/41] ram: introduce migration_bitmap_sync(), Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 17/41] buffered_file: rename opaque to migration_state, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 13/41] ram: create trace event for migration sync bitmap, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 15/41] migration: Add dirty_pages_rate to query migrate output, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 20/41] buffered_file: unfold migrate_fd_put_ready, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 18/41] buffered_file: opaque is MigrationState, Juan Quintela, 2012/10/02
- [Qemu-devel] [PATCH 16/41] BufferedFile: append, then flush, Juan Quintela, 2012/10/02