[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/11] static patches
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH 00/11] static patches |
Date: |
Sun, 14 Oct 2012 20:41:30 +0000 |
On Sun, Oct 14, 2012 at 8:32 PM, malc <address@hidden> wrote:
> On Sun, 14 Oct 2012, Blue Swirl wrote:
>
>> On Sun, Oct 14, 2012 at 7:58 PM, Blue Swirl <address@hidden> wrote:
>> > I made a small tool to detect unused functions and
>> > variables. Here's some fixes.
>>
>> Just run the attached tool in an object directory and after some time,
>> it will produce a list of suspect symbols:
>> AES_decrypt ( ./aes.o)
>> AES_encrypt ( ./aes.o)
>
>
>> AUD_get_elapsed_usec_in ( ./audio/audio.o)
>> AUD_get_elapsed_usec_out ( ./audio/audio.o)
>> AUD_init_time_stamp_in ( ./audio/audio.o)
>> AUD_init_time_stamp_out ( ./audio/audio.o)
>> AUD_is_active_in ( ./audio/audio.o)
>> AUD_is_active_out ( ./audio/audio.o)
>
> And those are all part of public API mentioned in audio.h
> Unused yes, but they are not static intentionally.
Yes, I checked those. The tool is a fool. There are other cases like
softfloat functions and TCG runtime parts which may be unused for some
host/target combinations. In theory, with lots of #ifdeffery or
splitting the files into smaller pieces, the unused parts could be
disabled, but that would be silly. A better approach might be using
some kind of AR library but it would still be a lot of effort for
little gain.
>
> [..snip..]
>
> --
> mailto:address@hidden
- [Qemu-devel] [PATCH 01/11] target-sparc: make do_unaligned_access static, (continued)
- [Qemu-devel] [PATCH 01/11] target-sparc: make do_unaligned_access static, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 02/11] vl.c: add missing static, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 03/11] vnc: add missing static and remove unused functions, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 05/11] m48t59: remove unused m48t59_set_addr, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 06/11] sun4c: remove unused functions, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 08/11] ppc: add missing static and remove unused functions, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 09/11] target-ppc: make some functions static, Blue Swirl, 2012/10/14
- Re: [Qemu-devel] [PATCH 00/11] static patches, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 11/11] exec: make some functions static, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 04/11] tap-win32: avoid a warning, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 07/11] slirp: remove unused function u_sleep, Blue Swirl, 2012/10/14
- [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions, Blue Swirl, 2012/10/14
- Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions, Peter Maydell, 2012/10/14
- Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions, Blue Swirl, 2012/10/14
- Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions, Peter Maydell, 2012/10/14
- Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions, Blue Swirl, 2012/10/14
- Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions, Peter Maydell, 2012/10/14
- Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions, Blue Swirl, 2012/10/19