|
From: | Kevin Wolf |
Subject: | Re: [Qemu-devel] [PATCH v2 2/3] qemu-img: Detect backing file chain infinite loops |
Date: | Tue, 16 Oct 2012 12:11:44 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 15.10.2012 14:44, schrieb Stefan Hajnoczi: > A malicious or corruption image can contain an infinite loop of backing > files. The qemu-img info --backing-chain command must not hang when > such files are encountered. > > Signed-off-by: Stefan Hajnoczi <address@hidden> This seems to do what is intended, but I think rather than fixing the 'qemu-img info' special case I'd have fixed bdrv_open() to detect the situation. Do we need to properly communicate what the broken image is with JSON output? This patch will only produce broken JSON in the failure case. Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |