[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd t
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set |
Date: |
Tue, 16 Oct 2012 14:57:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
On 10/16/2012 12:08 PM, Corey Bryant wrote:
> qmp_add_fd() gets an fd that was received over a socket with
> SCM_RIGHTS and adds it to an fd set. This patch adds support
> that will enable adding an fd that was inherited on the
> command line to an fd set.
>
> Note: All of the code added to monitor_fdset_add_fd(), with the
> exception of the error path for non-valid fdset-id, is code motion
> from qmp_add_fd().
>
> Signed-off-by: Corey Bryant <address@hidden>
> ---
> v2:
> -Removed Error** parameter from monitor_fdset_add_fd()
>
> v3:
> -Added Error** parameter back to monitor_fdset_add_fd()
> -Move 'if (!mon_fdset_cur)' change to patch 1 (address@hidden)
> -Move code that prevents removal of fd from fd set during init
> to it's own patch (address@hidden, address@hidden)
> -Mention code motion in commit message (address@hidden)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature