[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qmp: fix __accept() in qmp.py
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v2] qmp: fix __accept() in qmp.py |
Date: |
Tue, 16 Oct 2012 22:54:15 -0300 |
On Mon, 15 Oct 2012 16:58:02 -0400
Jeff Cody <address@hidden> wrote:
> In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation
> from __negotiate_capabilities(), which breaks _accept(). This causes
> failures in qemu-io python based tests (i.e. tests 030 and 040).
>
> This patch creates the sockfile in __accept() as well.
>
> Signed-off-by: Jeff Cody <address@hidden>
Acked-by: Luiz Capitulino <address@hidden>
> ---
> QMP/qmp.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/QMP/qmp.py b/QMP/qmp.py
> index 33c7d36..32510a1 100644
> --- a/QMP/qmp.py
> +++ b/QMP/qmp.py
> @@ -96,6 +96,7 @@ class QEMUMonitorProtocol:
> @raise QMPCapabilitiesError if fails to negotiate capabilities
> """
> self.__sock, _ = self.__sock.accept()
> + self.__sockfile = self.__sock.makefile()
> return self.__negotiate_capabilities()
>
> def cmd_obj(self, qmp_cmd):