Re: [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user

[Alex Barcelo]

Thanks Peter for all the feedback! I have just sent the v2 (have been
on holiday this weekend, a bit offline). I hope that this one is a
better patch.

Sorry Riku, I have doubleposted the new patch to you, I slipped on the
git send-email command, and sent the patch only to you at first (not
to the list). I corrected it but now you may have received twice. Next
time I will double check my git output :(

On Wed, Oct 10, 2012 at 5:37 PM, Peter Maydell <address@hidden> wrote:
> On 8 October 2012 19:42, Alex Barcelo <address@hidden> wrote:
>> okay, now I see that this lacks a lot of "presentation".
>
>> Before sending a v2, is there something more that I should correct?
>
> Well, yes, your cover letter could be a little more verbose, but I
> think mostly it's just that nobody's got round to reviewing the
> patches yet. I'll have a look at them in a moment.
>
> One thing that is definitely missing and is critical is that
> you need to include a Signed-off-by: line in your patches'
> commit messages: we cannot commit them without one.
> (http://wiki.qemu.org/Contribute/SubmitAPatch mentions this and
> has some other hints, if you haven't read it.)
>
>> And one netiquete question, test-breaking code should be in the
>> description (cover, 00/00)? On a next post in the same thread? Another
>> thread?
>
> In the cover letter is fine.
>
> -- PMM