[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use f
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN |
Date: |
Thu, 18 Oct 2012 19:19:40 +1100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Oct 18, 2012 at 08:37:20AM +0200, Alexander Graf wrote:
>
>
> On 18.10.2012, at 07:50, David Gibson <address@hidden> wrote:
>
> > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models
> > to represent a TLB entry contains a target_phys_addr_t. That works
> > reasonably for now, but is troublesome for saving the state, which we'll
> > want to do in future. target_phys_addr_t is a large enough type to contain
> > a physical address for any supported machine - and can thus, in theory at
> > least, vary depending on what machines are enabled other than the one
> > we're actually using right now. This makes it unsuitable for describing
> > in vmstate.
>
> Target_phys_addr_t is actually 64bit for all ppc targets today since
> some 32 bit boards support more than 32 bit address space ;).
Yes, I know. In fact since recently it's 64bit always on everything.
> The change still is fine though, as it makes that bit explicit.
Yes. What this is leading to is the new savevm code - there are no
vmstate helpers for target_phys_addr_t and my attempt to add them met
with at least semi-convincing arguments against.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
- [Qemu-devel] [PATCH 10/15] pseries: Allow RTAS tokens without a qemu handler, (continued)
- [Qemu-devel] [PATCH 10/15] pseries: Allow RTAS tokens without a qemu handler, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 06/15] pseries: Use #define for XICS base irq number, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 02/15] target-ppc: Rework storage of VPA registration state, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 07/15] pseries: Cleanup duplications of ics_valid_irq() code, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 12/15] pseries: Split xics irq configuration from state information, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 11/15] pseries: Add tracepoints to the XICS interrupt controller, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 04/15] target-ppc: Extend FPU state for newer POWER CPUs, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 08/15] pseries: Move XICS initialization before cpu initialization, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 13/15] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 03/15] pseries: Implement qemu initiated shutdowns using EPOW events, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 14/15] pseries: Implement PAPR NVRAM, David Gibson, 2012/10/18
- [Qemu-devel] [PATCH 15/15] pseries: Update SLOF for NVRAM support, David Gibson, 2012/10/18