|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 21/30] migration: move exit condition to migration thread |
| Date: | Thu, 18 Oct 2012 10:34:44 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 |
Il 18/10/2012 09:30, Juan Quintela ha scritto:
> - if (s->migration_state->complete) {
> + qemu_mutex_lock_iothread();
So, was it a bug that we were accessing ->complete without the BQL?
> + if (m->state != MIG_STATE_ACTIVE) {
> + DPRINTF("put_ready returning because of non-active state\n");
The contents of the debug message obsolete. Besides, I would just put
the two branches in the same "if (m->state != MIG_STATE_ACTIVE ||
m->complete)".
> + qemu_mutex_unlock_iothread();
> break;
> }
> + if (m->complete) {
> + qemu_mutex_unlock_iothread();
> + break;
> + }
> + qemu_mutex_unlock_iothread();
> +
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |