[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] quorum: Add quorum_open() and quorum_clos
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] quorum: Add quorum_open() and quorum_close(). |
Date: |
Tue, 23 Oct 2012 09:32:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
On 10/23/2012 06:23 AM, Benoît Canet wrote:
> Valid quorum resources look like
> quorum:threshold/total:path/to/image_1: ... :path/to/image_total
>
> ':' is used as a separator to allow to use networked path
> '\' is the escaping character for filename containing ':'
> '\' escape itself
>
> On the command line for quorum files "img,test.raw", "img2.raw"
Here, you used a comma,
> and "img3.raw" invocation look like:
>
> -drive file=quorum:2/3:img\\:test.raw:img2.raw:img3.raw
but here, you are using a colon for the underlying name 'img:test.raw'.
> (note the double \\)
You also didn't give an example of comma escaping using typical command
line comma escaping; but at least your example looks okay once you fix
the typo in the lead-in text. The code appears to match the commit message.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/11] Quorum disk image corruption resiliency, Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 01/11] quorum: Create quorum .c, add QuorumSingleAIOCB and QuorumAIOCB., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 04/11] quorum: Add quorum_aio_writev and its dependencies., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 03/11] quorum: Add quorum_open() and quorum_close()., Benoît Canet, 2012/10/23
- Re: [Qemu-devel] [PATCH 03/11] quorum: Add quorum_open() and quorum_close().,
Eric Blake <=
- [Qemu-devel] [PATCH 06/11] quorum: Add quorum_co_flush()., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 07/11] quorum: Add quorum_aio_readv., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 10/11] quorum: Add quorum_invalidate_cache()., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 08/11] quorum: Add quorum mechanism., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 09/11] quorum: Add quorum_getlength()., Benoît Canet, 2012/10/23
- [Qemu-devel] [PATCH 11/11] quorum: Add quorum_co_is_allocated., Benoît Canet, 2012/10/23