[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 01/13] pc/piix_pci: factor out smram/pam logi
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v1 01/13] pc/piix_pci: factor out smram/pam logic |
Date: |
Tue, 30 Oct 2012 21:26:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 30.10.2012 20:07, schrieb Anthony Liguori:
> Jason Baron <address@hidden> writes:
>
>> From: Isaku Yamahata <address@hidden>
>>
>> Factor out smram/pam logic for later use.
>> Which will be used by q35 too.
>>
>> address@hidden: changes for updated memory API]
>> Signed-off-by: Isaku Yamahata <address@hidden>
>> Signed-off-by: Jason Baron <address@hidden>
>
> This is really not the right approach to solving this problem.
>
> "pam" is not a device.
>
> Instead, the common bits here are essentially the northbridge logic.
> That's what we should model here.
>
> It's pretty simple actually. Just throw this all into a device where
> the memory regions are owned by the device. But also make the device
> own creation of all RAM (not just the areas controlled by PAM).
>
> Then embed the northbridge into the i440fx and q35.
Anthony/Wanpeng, any update on i440fx? Haven't heard of it since we
finally merged the PCI host bridge stuff for v1.2...
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v1 00/13] q35 patches for pci tree, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 02/13] Back out add of i21154, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 01/13] pc/piix_pci: factor out smram/pam logic, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 05/13] pc, pc_piix: split out pc nic initialization, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 03/13] blockdev: Introduce QEMUMachine->default_drive_if, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 06/13] pc: Move ioapic_init() from pc_piix.c to pc.c, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 04/13] blockdev: Introduce IF_AHCI, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 08/13] q35: Suppress SMM BIOS initialization under KVM, Jason Baron, 2012/10/29
- [Qemu-devel] [PATCH v1 10/13] Add a fallback bios file search, if -L fails., Jason Baron, 2012/10/29