[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/9] cadence_uart: More debug information
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 1/9] cadence_uart: More debug information |
Date: |
Thu, 1 Nov 2012 20:05:40 +0100 |
From: Peter Crosthwaite <address@hidden>
Add more helpful debug information to the cadence UART.
Signed-off-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/cadence_uart.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/cadence_uart.c b/hw/cadence_uart.c
index a7d0504..686e617 100644
--- a/hw/cadence_uart.c
+++ b/hw/cadence_uart.c
@@ -359,7 +359,7 @@ static void uart_write(void *opaque, hwaddr offset,
{
UartState *s = (UartState *)opaque;
- DB_PRINT(" offset:%x data:%08x\n", offset, (unsigned)value);
+ DB_PRINT(" offset:%x data:%08x\n", (unsigned)offset, (unsigned)value);
offset >>= 2;
switch (offset) {
case R_IER: /* ier (wts imr) */
@@ -405,12 +405,15 @@ static uint64_t uart_read(void *opaque, hwaddr offset,
offset >>= 2;
if (offset >= R_MAX) {
- return 0;
+ c = 0;
} else if (offset == R_TX_RX) {
uart_read_rx_fifo(s, &c);
- return c;
+ } else {
+ c = s->r[offset];
}
- return s->r[offset];
+
+ DB_PRINT(" offset:%x data:%08x\n", (unsigned)(offset << 2), (unsigned)c);
+ return c;
}
static const MemoryRegionOps uart_ops = {
--
1.7.12.1
- [Qemu-devel] [PULL 1.3 0/9] Trivial patches for 20 October to 1 November 2012, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 1/9] cadence_uart: More debug information,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/6] targphys.h: Don't define target_phys_addr_t for user-mode emulators, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 2/9] m68k: Return semihosting errno values correctly, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 1/6] ui/vnc: Only report/use TIGHT_PNG encoding if enabled., Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 3/6] target-arm/neon_helper: Remove obsolete FIXME comment, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 3/9] target-sparc: make do_unaligned_access static, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 4/6] configure: Remove unused parameters from main function, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 4/9] vl.c: add missing static, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 5/6] net/tap-win32: Fix compiler warning caused by missing include statement, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 5/9] vnc: add missing static, Stefan Hajnoczi, 2012/11/01
- [Qemu-devel] [PATCH 6/9] ppc: add missing static, Stefan Hajnoczi, 2012/11/01