[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier |
Date: |
Fri, 02 Nov 2012 08:26:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-10-31 16:30, Paolo Bonzini wrote:
> Otherwise, chardevs will not be able to create a bottom half as soon
> as that will require an AioContext.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> vl.c | 12 ++++++------
> 1 file modificato, 6 inserzioni(+), 6 rimozioni(-)
>
> diff --git a/vl.c b/vl.c
> index b3186fa..f84e969 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3311,6 +3311,12 @@ int main(int argc, char **argv, char **envp)
> }
> loc_set_none();
>
> + qemu_init_cpu_loop();
> + if (qemu_init_main_loop()) {
> + fprintf(stderr, "qemu_init_main_loop failed\n");
> + exit(1);
> + }
> +
> if (qemu_opts_foreach(qemu_find_opts("sandbox"), parse_sandbox, NULL,
> 0)) {
> exit(1);
> }
> @@ -3463,12 +3469,6 @@ int main(int argc, char **argv, char **envp)
>
> configure_accelerator();
>
> - qemu_init_cpu_loop();
> - if (qemu_init_main_loop()) {
> - fprintf(stderr, "qemu_init_main_loop failed\n");
> - exit(1);
> - }
> -
> machine_opts = qemu_opts_find(qemu_find_opts("machine"), 0);
> if (machine_opts) {
> kernel_filename = qemu_opt_get(machine_opts, "kernel");
>
This breaks daemonize as the BQL is marked as owned by the father
process. See also [1] in this context.
Can we move os_daemonize before that, or what are its dependencies? I
have an increasingly bad feeling about this code shuffling.
Jan
[1] http://thread.gmane.org/gmane.comp.emulators.qemu/179311
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier,
Jan Kiszka <=