Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.

[Blue Swirl]

On Fri, Nov 2, 2012 at 3:12 PM, Peter Maydell <address@hidden> wrote:
> On 2 November 2012 15:43, Paolo Bonzini <address@hidden> wrote:
>> Three fixes: 1) Darwin does not support weak aliases, use weak
>> references instead.  2) Darwin, NetBSD and OpenBSD do not have
>> sem_timedwait, implement counting semaphores with a mutex and
>> cv there.  3) Daemonize was broken, fixes are in patches 3-5.
>
> v2 patches 1 & 2 compile cleanly on macos and the resulting
> qemu seems to work (smoke tested only).

I'm still getting problems with Clang on Linux:

  CC    qemu-sockets.o
/src/qemu/qemu-sockets.c:64:12: error: function
'default_monitor_get_fd' is not needed and will not be emitted
[-Werror,-Wunneeded-internal-declaration]
static int default_monitor_get_fd(Monitor *mon, const char *name, Error **errp)
           ^
/src/qemu/qemu-sockets.c:73:12: error: function
'default_qemu_set_fd_handler2' is not needed and will not be emitted
[-Werror,-Wunneeded-internal-declaration]
static int default_qemu_set_fd_handler2(int fd,
           ^
2 errors generated.

Perhaps the weak magic isn't so great after all.

>
> thanks
> -- PMM