qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4 v5] vmware_vga: Coding style cleanup


From: BALATON Zoltan
Subject: Re: [Qemu-devel] [PATCH 1/4 v5] vmware_vga: Coding style cleanup
Date: Sat, 3 Nov 2012 13:51:14 +0100 (CET)
User-agent: Alpine 2.00 (GSO 1167 2008-08-23)

On Sat, 3 Nov 2012, Blue Swirl wrote:
But this and the others introduce new problems:
WARNING: suspect code indent for conditional statements (4, 9)
#301: FILE: hw/vmware_vga.c:320:
+    for (line = h; line > 0; line--, src += bypl, dst += bypl) {
          memcpy(dst, src, width);

WARNING: suspect code indent for conditional statements (4, 9)
#378: FILE: hw/vmware_vga.c:482:
+    if (s->vga.ds->cursor_define) {
          s->vga.ds->cursor_define(qc);

WARNING: suspect code indent for conditional statements (4, 9)
#393: FILE: hw/vmware_vga.c:495:
+    if (!s->config || !s->enable) {
          return 0;

WARNING: suspect code indent for conditional statements (4, 9)
#398: FILE: hw/vmware_vga.c:499:
+    if (num < 0) {
          num += CMD(max) - CMD(min);

Please recheck the patches.

I did check patches before submitting. It must have been my mailer mangling whitespace. Resent it again, now it should be correct at last. Sorry for the inconvenience.

Regards,
BALATON Zoltan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]