[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: Fix compiler warnings caused by ve
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: Fix compiler warnings caused by very large constants |
Date: |
Mon, 5 Nov 2012 08:03:40 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Nov 04, 2012 at 09:29:35PM +0100, Stefan Weil wrote:
> Those constants are larger than 32 bits and need a suffix to avoid
> warnings from some versions of gcc.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
> target-mips/dsp_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
> index b59133e..2ab9956 100644
> --- a/target-mips/dsp_helper.c
> +++ b/target-mips/dsp_helper.c
> @@ -3553,7 +3553,7 @@ target_ulong helper_dextr_rs_w(target_ulong ac,
> target_ulong shift,
> if (temp128 == 0) {
> temp[0] = 0x0FFFFFFFF;
> } else {
> - temp[0] = 0x0100000000;
> + temp[0] = 0x0100000000ULL;
> }
> set_DSPControl_overflow_flag(1, 23, env);
> }
> @@ -3653,7 +3653,7 @@ target_ulong helper_extr_s_h(target_ulong ac,
> target_ulong shift,
> if (temp > (int64_t)0x7FFF) {
> temp = 0x00007FFF;
> set_DSPControl_overflow_flag(1, 23, env);
> - } else if (temp < (int64_t)0xFFFFFFFFFFFF8000) {
> + } else if (temp < (int64_t)0xFFFFFFFFFFFF8000LL) {
> temp = 0xFFFF8000;
> set_DSPControl_overflow_flag(1, 23, env);
> }
Blue Swirl proposed the same patch a bit earlier then you, and I have
just applied it.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net