[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs |
Date: |
Mon, 05 Nov 2012 11:20:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121026 Thunderbird/10.0.10 |
On 11/05/12 05:20, David Gibson wrote:
> Here's an updated version that uses a temporary buffer.
>
> From 588a8f874c8d5a658ef95e35164e182a915091db Mon Sep 17 00:00:00 2001
> From: David Gibson <address@hidden>
> Date: Mon, 5 Nov 2012 14:29:01 +1100
> Subject: [PATCH] xhci: Fix some DMA host endian bugs
>
> The xhci device does correct endian switches on the results of some DMAs
> but not all. In particular, there are many DMAs of what are essentially
> arrays of 32-bit integers which never get byteswapped. This causes them
> to be interpreted incorrectly on big-endian hosts, since (as per the xhci
> spec) these arrays are always little-endian in guest memory.
>
> This patch adds some helper functions to fix these bugs. This may not be
> all the endian bugs in the xhci code, but it's certainly some of them and
> the Linux guest xhci driver certainly gets further with these fixes.
Patch added to usb patch queue.
thanks,
Gerd