qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] machine: add default_devices field to QEMUM


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 3/4] machine: add default_devices field to QEMUMachine
Date: Mon, 05 Nov 2012 13:27:11 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Anthony Liguori <address@hidden> writes:

> This allows a machine to describe default devices that are only available
> when -nodefaults is not present.
>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
>  hw/boards.h |  6 ++++++
>  vl.c        | 13 +++++++++++++
>  2 files changed, 19 insertions(+)
>
> diff --git a/hw/boards.h b/hw/boards.h
> index 813d0e5..85b2887 100644
> --- a/hw/boards.h
> +++ b/hw/boards.h
> @@ -18,6 +18,11 @@ typedef void QEMUMachineInitFunc(QEMUMachineInitArgs 
> *args);
>  
>  typedef void QEMUMachineResetFunc(void);
>  
> +typedef struct DeviceDescription {
> +    const char *description;
> +} DeviceDescription;

A comment explaning syntax of @description (just like argument of
-device, as far as I can tell) would be nice.

Not sure wrapping in a struct is worth it.

> +
> +
>  typedef struct QEMUMachine {
>      const char *name;
>      const char *alias;
> @@ -37,6 +42,7 @@ typedef struct QEMUMachine {
>      GlobalProperty *compat_props;
>      struct QEMUMachine *next;
>      const char *hw_version;
> +    DeviceDescription *default_devices;
>  } QEMUMachine;
>  
>  int qemu_register_machine(QEMUMachine *m);
[...]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]