[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC |
Date: |
Fri, 09 Nov 2012 13:00:26 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.10) Gecko/20121028 Icedove/10.0.10 |
On 09.11.2012 03:55, BALATON Zoltan wrote:
> On Thu, 8 Nov 2012, Gerd Hoffmann wrote:
>>> I think this is fixing this at the wrong level. Either we
>>> should require that drivers (in this case vmware_vga.c)
>>> must not call dpy_gfx_update() with out of range values,
>>> or we should do the clipping in the console.c layer, but
>>> I don't think requiring every UI backend to clip is the
>>> right thing. Anthony?
>>
>> Agree. IMHO vmware_vga.c is at fault here and should be fixed. We can
>> add some asserts to console.[ch] to enforce this ...
>
> Would the attached patch help?
I fixed this 2 times, and I remember two other people fixing
the same thing too already. Lemme find some refs...
thread.gmane.org/gmane.comp.emulators.qemu/166064
---
Is it the same as https://bugs.launchpad.net/bugs/918791 ?
At least it appears to be the same theme... But there,
the patch (https://launchpadlibrarian.net/94916786/qemu-vmware.debdiff)
also updates width/height. My comment:
https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/918791/comments/21
---
Adding some Cc's....
- [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerhard Wiesinger, 2012/11/01
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerhard Wiesinger, 2012/11/04
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Peter Maydell, 2012/11/08
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerhard Wiesinger, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Peter Maydell, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Anthony Liguori, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Peter Maydell, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerd Hoffmann, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Marek Vasut, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Peter Maydell, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerhard Wiesinger, 2012/11/10
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Marek Vasut, 2012/11/10