[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field |
Date: |
Tue, 13 Nov 2012 11:45:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 12/11/2012 20:17, Charles Arnold ha scritto:
> Ping?
>
> Is this ok?
>
> - Charles
>
>>>> On 11/2/2012 at 09:54 AM, in message <address@hidden>, Charles
> Arnold wrote:
>> block/vpc: Initialize the uuid field in the footer with a generated uuid.
>>
>> Signed-off-by: Charles Arnold <address@hidden>
>>
>> diff --git a/block/vpc.c b/block/vpc.c
>> index b6bf52f..f14c6ae 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -26,6 +26,9 @@
>> #include "block_int.h"
>> #include "module.h"
>> #include "migration.h"
>> +#if defined(CONFIG_UUID)
>> +#include <uuid/uuid.h>
>> +#endif
>>
>> /**************************************************************/
>>
>> @@ -739,7 +742,9 @@ static int vpc_create(const char *filename,
>> QEMUOptionParameter *options)
>>
>> footer->type = be32_to_cpu(disk_type);
>>
>> - /* TODO uuid is missing */
>> +#if defined(CONFIG_UUID)
>> + uuid_generate(footer->uuid);
>> +#endif
>>
>> footer->checksum = be32_to_cpu(vpc_checksum(buf, HEADER_SIZE));
>>
Reviewed-by: Paolo Bonzini <address@hidden>