[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the d
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors |
Date: |
Thu, 15 Nov 2012 09:28:56 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121026 Thunderbird/10.0.10 |
On 11/15/12 09:23, Jan Kiszka wrote:
> The Linux is more tolerant here as well: Just stop parsing the device
> descriptors when an error is detected but do not reset what was found
> so far. This allows to run buggy devices with partially invalid
> descriptors.
> -error:
> - usb_ep_reset(&s->dev);
> - return 1;
I'd prefer to keep the error jump target to handle the parse error here.
Dumping the reset there is fine with me, but I'd prefer this event being
logged (trace point or stderr message or both) to ease trouble shooting
in case a device doesn't behave as expected.
thanks,
Gerd