[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Make
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs |
Date: |
Sun, 18 Nov 2012 15:55:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 |
Il 18/11/2012 13:56, Wenchao Xia ha scritto:
> δΊ 2012-11-16 19:12, Paolo Bonzini ει:
>> Il 16/11/2012 11:58, Wenchao Xia ha scritto:
>>>>> Sub Makefile may need qapi generated files, so move them to
>>>>> Makefile.objs,
>>>>> In this way Makfile.objs control file auto generation.
>>>>
>>>> No objection in principle, but why are you doing this? Does it fix
>>>> anything?
>>>
>>> It seems tools or block objects files are depending on qapi files,
>>
>> Yes, block files are.
>>
>>> and libqblock needs tools. So without it out of tree build of libqblock
>>> would fail.
>>
>> The effect of this patch is to include the rules in libqblock's own
>> Makefile.
>>
>> libqblock indeed needs to compile these files to .lo. However,
>> regeneration of the C source code and header shouldn't be needed there.
>> I think you're missing a dependency in the toplevel Makefile's
>> "libqblock.la" rule.
>>
> yes, I'll try avoid generation of those C files in sub directory.
> Still moving generation rules all into Makefile.obs seems right to me.
Makefile.objs rules are common to all subdirectories, including
*-softmmu and *-linux-user. This is not what you want in this case.
Paolo
- Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly, (continued)
- Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly, Wenchao Xia, 2012/11/16
- Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly, Paolo Bonzini, 2012/11/16
- Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly, Wenchao Xia, 2012/11/16
- Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly, Paolo Bonzini, 2012/11/16
- Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly, Wenchao Xia, 2012/11/18
[Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs, Wenchao Xia, 2012/11/16
[Qemu-devel] [PATCH V9 4/8] block export function path_has_protocol, Wenchao Xia, 2012/11/16
[Qemu-devel] [PATCH V9 5/8] libqblock build system, Wenchao Xia, 2012/11/16
[Qemu-devel] [PATCH V9 6/8] libqblock type defines, Wenchao Xia, 2012/11/16
[Qemu-devel] [PATCH V9 7/8] libqblock API, Wenchao Xia, 2012/11/16
[Qemu-devel] [PATCH V9 8/8] libqblock test example, Wenchao Xia, 2012/11/16