[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entrop
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy |
Date: |
Tue, 20 Nov 2012 19:41:00 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Amit Shah <address@hidden> writes:
> If we got fewer bytes from the backend than requested, don't poke the
> backend for more bytes; the guest will ask for more (or if the guest has
> already asked for more, the backend knows about it via handle_input()).
>
> Signed-off-by: Amit Shah <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Regards,
Anthony Liguori
> ---
> hw/virtio-rng.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
> index 6c49bb2..cf5a8ff 100644
> --- a/hw/virtio-rng.c
> +++ b/hw/virtio-rng.c
> @@ -80,13 +80,6 @@ static void chr_read(void *opaque, const void *buf, size_t
> size)
> virtqueue_push(vrng->vq, &elem, len);
> }
> virtio_notify(&vrng->vdev, vrng->vq);
> -
> - /*
> - * Lastly, if we had multiple elems queued by the guest, and we
> - * didn't have enough data to fill them all, indicate we want more
> - * data.
> - */
> - virtio_rng_process(vrng);
> }
>
> static void virtio_rng_process(VirtIORNG *vrng)
> --
> 1.8.0
- [Qemu-devel] [PATCH 0/4] [For 0.13] virtio-rng: Fixes, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy, Amit Shah, 2012/11/20
- Re: [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy,
Anthony Liguori <=
- [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 4/4] virtio-rng: fix typos, comments, Amit Shah, 2012/11/20