[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal |
Date: |
Tue, 20 Nov 2012 19:41:22 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Amit Shah <address@hidden> writes:
> Disable the rate-limit timer on device remove (e.g. hot-unplug).
>
> Signed-off-by: Amit Shah <address@hidden>
Nice catch.
Reviewed-by: Anthony Liguori <address@hidden>
Regards,
Anthony Liguori
> ---
> hw/virtio-rng.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c
> index cf5a8ff..c8a6da7 100644
> --- a/hw/virtio-rng.c
> +++ b/hw/virtio-rng.c
> @@ -194,6 +194,8 @@ void virtio_rng_exit(VirtIODevice *vdev)
> {
> VirtIORNG *vrng = DO_UPCAST(VirtIORNG, vdev, vdev);
>
> + qemu_del_timer(vrng->rate_limit_timer);
> + qemu_free_timer(vrng->rate_limit_timer);
> unregister_savevm(vrng->qdev, "virtio-rng", vrng);
> virtio_cleanup(vdev);
> }
> --
> 1.8.0
- [Qemu-devel] [PATCH 0/4] [For 0.13] virtio-rng: Fixes, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration, Amit Shah, 2012/11/20
- [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal, Amit Shah, 2012/11/20
- Re: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal,
Anthony Liguori <=
- [Qemu-devel] [PATCH 4/4] virtio-rng: fix typos, comments, Amit Shah, 2012/11/20