Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

[Peter Maydell]

On 17 November 2012 13:10, Peter Maydell <address@hidden> wrote:
> On 17 November 2012 13:02, Andreas Färber <address@hidden> wrote:
>> Am 16.11.2012 17:37, schrieb Peter Maydell:
>>> +if test "$(uname -s)" = "Darwin"; then
>>> +  # On MacOS X the standard supported system compiler is 'cc' (usually 
>>> clang),
>>> +  # and 'gcc' is a legacy llvm-gcc which is rather elderly and best 
>>> avoided.
>>
>> This comment strikes me as wrong in this generality. It should at least
>> be qualified with OSX version numbers.
>
> How about "and if 'gcc' is not the same as 'cc' then it is a legacy llvm-gcc
> which is rather elderly and best avoided" ? I'd rather not get into having
> to research which versions of OSX shipped with which compiler as 'cc',
> when really the point is that 'cc' will always give you whichever compiler
> Apple thought was the best default for that version.

Andreas: ping? are you happy with this suggested rephrasing? Do you
think this is 1.3 material? (now the static-stublib stuff is in it's
less critical, but it still seems like the right idea...)

thanks
-- PMM