qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize chan


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions
Date: Sun, 25 Nov 2012 14:47:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

On 11/25/2012 12:45 PM, Jan Kiszka wrote:
> On 2012-11-25 11:18, Avi Kivity wrote:
>> On 11/05/2012 02:37 PM, Jan Kiszka wrote:
>>>>
>>>> As I noted, init and destroy cannot cause a topology update.
>>>
>>> Ah, right. Why are we wrapping them in transaction_begin/commit at all then?
>>>
>> 
>> We aren't.
>> 
>> 
>> void memory_region_destroy(MemoryRegion *mr)
>> {
>>     assert(QTAILQ_EMPTY(&mr->subregions));
>>     assert(memory_region_transaction_depth == 0);
>> 
> 
> We were talking about address_space_init/destroy.

This is to force a re-rendering of the address space, so that listeners
see the construction/destruction.  Simply assigning as->root wouldn't do
that.

This kind of reliance on side effects should be documented with a
comment (and forbidden to anything that is outside the implementation).
 My bad.

-- 
error compiling committee.c: too many arguments to function



reply via email to

[Prev in Thread] Current Thread [Next in Thread]