Re: [Qemu-devel] [PATCH for 1.3] target-i386: cpu: add missing flags to Haswell CPU model

[Eduardo Habkost]

On Sun, Nov 25, 2012 at 07:33:12PM +0100, Andreas Färber wrote:
> Am 22.11.2012 16:31, schrieb Eduardo Habkost:
> > When adding the Haswell CPU model, I intended to make it a superset of the
> > features present on the SandyBridge model, but I have removed the SEP and
> > RDTSCP features from the feature list by mistake. This patch adds the 
> > missing
> > SEP and RDTSCP features (that are present on SandyBridge) to Haswell.
> > 
> > Reported-by: Martin Kletzander <address@hidden>
> > Signed-off-by: Eduardo Habkost <address@hidden>
> 
> Acked-by: Andreas Färber <address@hidden>
> 
> FWIW this is showing where QOM's imperative approach combined with
> inheritance could greatly simplify things beyond your subclasses RFC.
> Unfortunately I am not intimately familiar with all these models, so
> counting on your help there. :)

I am now convinced that an imperative approach may be reasonable, if we
make the results of the imperative code introspectable (so we can expose
information about the CPU models to libvirt). This will probably be
possible if we use different class_init functions for each class,
instead of different instance_init functions.

-- 
Eduardo