[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport*
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport* |
Date: |
Tue, 27 Nov 2012 01:10:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 19.09.2012 13:50, schrieb Julien Grall:
> This patch replaces all register_ioport* by a MemorySection.
> It permits to use the new Memory stuff like listener.
>
> Moreover, the PCI is added as an argument for apm_init, so we
> can register IO inside the pci IO address space.
>
> Signed-off-by: Julien Grall <address@hidden>
Following today's q35 merge I needed the following diff to fix the build:
diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c
index 2fc83a4..7de5427 100644
--- a/hw/lpc_ich9.c
+++ b/hw/lpc_ich9.c
@@ -472,7 +472,7 @@ static int ich9_lpc_initfn(PCIDevice *d)
lpc->isa_bus = isa_bus;
ich9_cc_init(lpc);
- apm_init(&lpc->apm, ich9_apm_ctrl_changed, lpc);
+ apm_init(d, &lpc->apm, ich9_apm_ctrl_changed, lpc);
return 0;
}
Julien/Jason, can you please verify that this is the correct device to pass?
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg