[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_
|
From: |
Max Filippov |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386: honor CR0_PG_MASK in cpu_get_phys_page_debug |
|
Date: |
Wed, 5 Dec 2012 14:36:20 +0300 |
On Wed, Dec 5, 2012 at 3:15 PM, Andreas Färber <address@hidden> wrote:
> Am 17.11.2012 21:52, schrieb Max Filippov:
>> cpu_get_phys_page_debug is not in sync with cpu_x86_handle_mmu_fault:
>> the latter first checks CR0_PG_MASK and only after CR4_PAE_MASK.
>>
>> This fixes odd gdb code display with PAE enabled.
>>
>> Signed-off-by: Max Filippov <address@hidden>
>
> You write, they are "not in sync". Would it be possible to share code to
> assure this, e.g., by calling a helper function from both?
I'd say yes though that'd be a bigger change. I'll try to do it.
--
Thanks.
-- Max