[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk. |
Date: |
Thu, 6 Dec 2012 10:13:16 +0000 |
On 6 December 2012 09:53, Andreas Färber <address@hidden> wrote:
> Am 06.12.2012 10:21, schrieb KONRAD Frédéric:
>> I agree with that, but, there is an issue :
>> The refactored VirtIOBlk is a device and seems to work, but the device
>> which use this VirtIOBlock
>> (eg virtio-blk-pci) are just allocating a structure ( in
>> virtio_common_init ).
>>
>> That's why this patch is breaking virtio-blk-pci.
>
> Don't understand that part due to lack of virtio knowledge...
> Patch 5/6 introduces VirtIODevice as sitting on TYPE_VIRTIO_BUS. So with
> this patch VirtIOBlk is moving to that new bus and virtio-blk-pci should
> only be necessary as a command line option alias for backwards
> compatibility, no?
It can't just be a command line alias, or we will break migration.
It has to be a simple device that composes together the virtio-pci
and virtio-blk devices, plus legacy support for properties and
migration state, I think.
-- PMM
- [Qemu-devel] [RFC PATCH v5 5/6] virtio-device : Refactor virtio-device., (continued)
- [Qemu-devel] [RFC PATCH v5 5/6] virtio-device : Refactor virtio-device., fred . konrad, 2012/12/04
- [Qemu-devel] [RFC PATCH v5 3/6] virtio-pci-bus : Introduce virtio-pci-bus., fred . konrad, 2012/12/04
- [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., fred . konrad, 2012/12/04
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Peter Maydell, 2012/12/05
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Andreas Färber, 2012/12/05
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Andreas Färber, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk.,
Peter Maydell <=
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Peter Maydell, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., Andreas Färber, 2012/12/06
- Re: [Qemu-devel] [RFC PATCH v5 6/6] virtio-blk : Refactor virtio-blk., KONRAD Frédéric, 2012/12/06