[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of savevm routines |
Date: |
Mon, 10 Dec 2012 09:24:33 -0600 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Peter Maydell <address@hidden> writes:
> On 10 December 2012 14:29, Anthony Liguori <address@hidden> wrote:
>> Signed-off-by: Anthony Liguori <address@hidden>
>> ---
>> qemu-file.h | 7 +++++++
>> savevm.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 52 insertions(+)
>>
>> diff --git a/qemu-file.h b/qemu-file.h
>> index d64bdbb..ac5286c 100644
>> --- a/qemu-file.h
>> +++ b/qemu-file.h
>> @@ -94,6 +94,9 @@ static inline void qemu_put_ubyte(QEMUFile *f, unsigned
>> int v)
>> void qemu_put_be16(QEMUFile *f, unsigned int v);
>> void qemu_put_be32(QEMUFile *f, unsigned int v);
>> void qemu_put_be64(QEMUFile *f, uint64_t v);
>> +void qemu_put_le16(QEMUFile *f, unsigned int v);
>> +void qemu_put_le32(QEMUFile *f, unsigned int v);
>> +void qemu_put_le64(QEMUFile *f, uint64_t v);
>
> Do we want to add a comment here somewhere that says the le versions
> are for backcompat with a specific thing and the be ones are the
> ones to use in new code (well, new code not using vmstate)?
Yeah, that's a good idea. I've unfortunately found a couple more cases
of this (writing native endian to the wire).
Regards,
Anthony Liguori
>
> -- PMM
- Re: [Qemu-devel] [PATCH 3/4] virtio: modify savevm to have a stable wire format, (continued)
[Qemu-devel] [PATCH 2/4] virtio: add wrapper for saving/restoring virtqueue elements, Anthony Liguori, 2012/12/10
[Qemu-devel] [PATCH 1/4] savevm: introduce little endian variants of savevm routines, Anthony Liguori, 2012/12/10
[Qemu-devel] [PATCH 4/4] virtio: bump migration version number, Anthony Liguori, 2012/12/10
Re: [Qemu-devel] [RFC 0/4] virtio: stabilize migration format, Stefan Hajnoczi, 2012/12/11