[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support. |
Date: |
Fri, 14 Dec 2012 15:05:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11 |
On 12/14/12 14:45, Paolo Bonzini wrote:
> Il 14/12/2012 14:18, Gerd Hoffmann ha scritto:
>> Hi,
>>
>>> { 'enum': 'ChardevFileMode', 'data':
>>> # pty = console under Windows
>>> # serial = tty under POSIX
>>> [ 'file', 'pipe', 'parport', 'pty', 'serial' ] }
>>
>> Hmm, why this enum? I'd stay close to -chardev, i.e. specify the type
>> by backend name.
>
> Because...
>
>>> { 'enum: 'ChardevFileSource', 'data':
>>> [ 'path', 'fd' ] }
>>
>> I guess I'd just create a new backend type for file descriptor passing
>> instead of fitting that into all the existing ones.
>
> ... are you passing a file descriptor for a pipe, a file or a
> parallel/serial port?
The open function of the file-based backends basically do (1) create
file handles and (2) call qemu_chr_open_fd(). So of you already have an
fd the differences are gone. Well, almost. tty has an special ioctl
callback to configure line speed.
cheers,
Gerd
- [Qemu-devel] [PATCH RESENT 0/3] chardev hotplug patch series, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Eric Blake, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14