[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/8] spice-qemu-char: write to chardev whatever amou
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 3/8] spice-qemu-char: write to chardev whatever amount it can read |
Date: |
Mon, 17 Dec 2012 14:04:34 +0100 |
From: Marc-André Lureau <address@hidden>
The current code waits until the chardev can read MIN(len, VMC_MAX)
But some chardev may never reach than amount, in fact some of them
will only ever accept write of 1. Fix the min computation and remove
the VMC_MAX constant.
Signed-off-by: Gerd Hoffmann <address@hidden>
---
spice-qemu-char.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 09aa22d..665efd3 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -14,8 +14,6 @@
} \
} while (0)
-#define VMC_MAX_HOST_WRITE 2048
-
typedef struct SpiceCharDriver {
CharDriverState* chr;
SpiceCharDeviceInstance sin;
@@ -35,8 +33,8 @@ static int vmc_write(SpiceCharDeviceInstance *sin, const
uint8_t *buf, int len)
uint8_t* p = (uint8_t*)buf;
while (len > 0) {
- last_out = MIN(len, VMC_MAX_HOST_WRITE);
- if (qemu_chr_be_can_write(scd->chr) < last_out) {
+ last_out = MIN(len, qemu_chr_be_can_write(scd->chr));
+ if (last_out <= 0) {
break;
}
qemu_chr_be_write(scd->chr, p, last_out);
--
1.7.1
- [Qemu-devel] [PULL 0/8] spice patch queue, Gerd Hoffmann, 2012/12/17
- [Qemu-devel] [PATCH 4/8] spice-qemu-char: factor out CharDriverState creation, Gerd Hoffmann, 2012/12/17
- [Qemu-devel] [PATCH 3/8] spice-qemu-char: write to chardev whatever amount it can read,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 6/8] spice-qemu-char: keep a list of spice chardev, Gerd Hoffmann, 2012/12/17
- [Qemu-devel] [PATCH 7/8] spice-qemu-char: register spicevmc ports during qemu_spice_init(), Gerd Hoffmann, 2012/12/17
- [Qemu-devel] [PATCH 8/8] docs: add spice-port-fqdn.txt, Gerd Hoffmann, 2012/12/17
- [Qemu-devel] [PATCH 2/8] qxl+vnc: register a vm state change handler for dummy spice_server, Gerd Hoffmann, 2012/12/17
- [Qemu-devel] [PATCH 5/8] spice-qemu-char: add spiceport chardev, Gerd Hoffmann, 2012/12/17
- [Qemu-devel] [PATCH 1/8] qxl: save qemu_create_displaysurface_from result, Gerd Hoffmann, 2012/12/17
- Re: [Qemu-devel] [PULL 0/8] spice patch queue, Anthony Liguori, 2012/12/18