[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove |
Date: |
Tue, 18 Dec 2012 17:37:53 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 21, 2012 at 07:52:48AM +0800, 陳韋任 (Wei-Ren Chen) wrote:
> When tb_remove was first commited at fd6ce8f6, there were three different
> calls pass different names to offsetof. In current codebase, the other two
> calls are replaced with tb_page_remove. There is no need to have a general
> tb_remove. Omit passing the third parameter and using tb1->phys_hash_next
> directly.
>
> Signed-off-by: Chen Wei-Ren <address@hidden>
> ---
>
> v2: Address Peter's comment.
> - place comment used belong tb_remove above tb_phys_invalidate.
> - remove unnecessary bracket.
>
> exec.c | 12 +++++-------
> 1 files changed, 5 insertions(+), 7 deletions(-)
Please rebase onto qemu.git/master.
Stefan