[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/10] fix build error on ARM due to wrong glibc che
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 07/10] fix build error on ARM due to wrong glibc check |
Date: |
Tue, 18 Dec 2012 17:51:14 +0100 |
From: John Spencer <address@hidden>
the test for glibc < 2 "succeeds" wrongly for any non-glibc C library,
and breaks the build on musl libc.
we must first test if __GLIBC__ is defined at all, before using it
unconditionally.
Signed-off-by: John Spencer <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
user-exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/user-exec.c b/user-exec.c
index 1185cb0..5863b9f 100644
--- a/user-exec.c
+++ b/user-exec.c
@@ -436,7 +436,7 @@ int cpu_signal_handler(int host_signum, void *pinfo,
unsigned long pc;
int is_write;
-#if (__GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ <= 3))
+#if defined(__GLIBC__) && (__GLIBC__ < 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__
<= 3))
pc = uc->uc_mcontext.gregs[R15];
#else
pc = uc->uc_mcontext.arm_pc;
--
1.8.0.2
- [Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 01/10] net, hub: fix the indent in the comments, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 04/10] zynq_slcr: Compile time warning fixes., Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 05/10] arm_gic: Add cpu nr to Raised IRQ message, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 03/10] pflash_cfi0x: Send debug messages to stderr, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 06/10] gitignore: Add virtfs-proxy-helper, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 07/10] fix build error on ARM due to wrong glibc check,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward decl of setgroups(), Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 09/10] vmmouse_reset(): remove minimal code duplication, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 10/10] configure: Earlier pkg-config probe, Stefan Hajnoczi, 2012/12/18
- [Qemu-devel] [PATCH 02/10] pflash_cfi01: qemu_log_mask "unimplemented" msg, Stefan Hajnoczi, 2012/12/18
- Re: [Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012, Anthony Liguori, 2012/12/18