[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed i
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing suffixed integer |
Date: |
Wed, 26 Dec 2012 10:51:46 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Dec 23, 2012 at 02:34:21PM -0600, Anthony Liguori wrote:
> Igor Mammedov <address@hidden> writes:
>
> > v2:
> > * Naming changes:
> > - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/
> > - use 'suffix_factor' instead of 'unit'
> > * Added documentation to visit_type_suffixed_int()
> > * Fixed errp check.
> > * Style fixes
>
> This is not how visitors are supposed to be used.
>
> Just treat tsc_freq as a string property and parse it in the setter.
So, why visit_type_size() does exist? Should we work to eliminate it? If
not, why is it different from a "frequency" type?
--
Eduardo