[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/20] target-i386: set custom 'xlevel' without
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 15/20] target-i386: set custom 'xlevel' without intermediate x86_def_t |
Date: |
Thu, 27 Dec 2012 17:30:09 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 27, 2012 at 03:59:31PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> target-i386/cpu.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 0764015..d8af528 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1338,7 +1338,9 @@ static int cpu_x86_parse_featurestr(x86_def_t
> *x86_cpu_def, char *features,
> ", fixup will be depricated in future
> versions\n");
> numvalue += 0x80000000;
> }
> - x86_cpu_def->xlevel = numvalue;
> + val = g_strdup_printf("%u", numvalue);
> + qdict_put(*props, featurestr, qstring_from_str(val));
> + g_free(val);
I would write that as:
QString *s = qstring_new();
qstring_append_int(s, numvalue);
qdict_put(*props, featurestr, s);
So there would be no need for manual memory handling.
> } else if (!strcmp(featurestr, "vendor")) {
> qdict_put(*props, featurestr, qstring_from_str(val));
> } else if (!strcmp(featurestr, "model_id")) {
> --
> 1.7.1
>
--
Eduardo
- Re: [Qemu-devel] [PATCH 11/20] target-i386: remove vendor_override field from CPUX86State, (continued)
- [Qemu-devel] [PATCH 06/20] target-i386: move out CPU features initialization in separate func, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 08/20] target-i386: move kvm_check_features_against_host() check to realize time, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 12/20] target-i386: prepare cpu_x86_parse_featurestr() to return a set of key, value property pairs, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 16/20] target-i386: set custom 'level' without intermediate x86_def_t, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 15/20] target-i386: set custom 'xlevel' without intermediate x86_def_t, Igor Mammedov, 2012/12/27
- Re: [Qemu-devel] [PATCH 15/20] target-i386: set custom 'xlevel' without intermediate x86_def_t,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 17/20] target-i386: set custom 'model-id' without intermediate x86_def_t, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 20/20] target-i386: set custom 'family' without intermediate x86_def_t, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 14/20] target-i386: print depricated warning if xlevel < 0x80000000, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 18/20] target-i386: set custom 'stepping' without intermediate x86_def_t, Igor Mammedov, 2012/12/27
- [Qemu-devel] [PATCH 19/20] target-i386: set custom 'model' without intermediate x86_def_t, Igor Mammedov, 2012/12/27