Re: [Qemu-devel] [PATCH 3/4] hw: Add test device for unittests execution

[Alexander Graf]

Am 04.01.2013 um 22:44 schrieb "Stefan Weil" <address@hidden>:

>> From: Lucas Meneghel Rodrigues <address@hidden>
>> 
>> Add a test device which supports the kvmctl ioports,
>> so one can run the KVM unittest suite.
>> 
>> Intended Usage:
>> 
>> qemu-system-x86_64 -nographic \
>>    -device pc-testdev \
>>    -device isa-debug-exit,iobase=0xf4,iosize=0x04 \
>>    -kernel /path/to/kvm/unittests/msr.flat
>> 
>> Where msr.flat is one of the KVM unittests, present on a
>> separate repo,
>> 
>> git://git.kernel.org/pub/scm/virt/kvm/kvm-unit-tests.git
>> 
>> [ kraxel: more memory api + qom fixes ]
>> 
>> CC: Paolo Bonzini <address@hidden>
>> Signed-off-by: Alexander Graf <address@hidden>
>> Signed-off-by: Marcelo Tosatti <address@hidden>
>> Signed-off-by: Lucas Meneghel Rodrigues <address@hidden>
>> Signed-off-by: Gerd Hoffmann <address@hidden>
>> ---
>> hw/i386/Makefile.objs |    1 +
>> hw/pc-testdev.c       |  182
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 183 insertions(+), 0 deletions(-)
>> create mode 100644 hw/pc-testdev.c
> 
> 
> This patch breaks QEMU git master for MinGW.
> 
>  CC    i386-softmmu/hw/i386/../pc-testdev.o
> /qemu/hw/i386/../pc-testdev.c:38:22: warning: sys/mman.h: Datei oder
> Verzeichnis nicht gefunden
> /qemu/hw/i386/../pc-testdev.c: In function ‘test_flush_page’:
> /qemu/hw/i386/../pc-testdev.c:103: warning: implicit declaration of
> function ‘mprotect’
> ...
> 
> Should hw/pc-testdev.c be only compiled when CONFIG_KVM is defined?

It should work fine with tcg too. How about guarding the mprotect with an 
#ifdef __linux__?

Alex

> 
> Regards,
> 
> Stefan
> 
>