qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions
Date: Tue, 8 Jan 2013 10:03:36 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Jan 07, 2013 at 03:38:39PM -0500, Nickolai Zeldovich wrote:
> memcpy() for overlapping regions is undefined behavior; use memmove()
> instead in readline_hist_add().
> 
> Signed-off-by: Nickolai Zeldovich <address@hidden>
> ---
>  readline.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I made a slight modification: keep the tab characters since the
surrounding code still uses them.

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]