[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] e1000: make ICS write-only
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH] e1000: make ICS write-only |
Date: |
Wed, 09 Jan 2013 23:28:29 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
On 01/09/2013 06:51 PM, Michael S. Tsirkin wrote:
> Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968,
> qemu started updating ICS register when interrupt
> is sent, with the intent to match spec better
> (guests do not actually read this register).
> However, the function set_interrupt_cause where ICS
> is updated is often called internally by
> device emulation so reading it does not produce the last value
> written by driver. Looking closer at the spec,
> it documents ICS as write-only, so there's no need
> to update it at all. I conclude that while harmless this line is useless
> code so removing it is a bit cleaner than keeping it in.
>
> Tested with windows and linux guests.
>
> Cc: Bill Paul <address@hidden>
> Reported-by: Yan Vugenfirer <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/e1000.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/e1000.c b/hw/e1000.c
> index 92fb00a..928d804 100644
> --- a/hw/e1000.c
> +++ b/hw/e1000.c
> @@ -230,7 +230,6 @@ set_interrupt_cause(E1000State *s, int index, uint32_t
> val)
> val |= E1000_ICR_INT_ASSERTED;
> }
> s->mac_reg[ICR] = val;
> - s->mac_reg[ICS] = val;
> qemu_set_irq(s->dev.irq[0], (s->mac_reg[IMS] & s->mac_reg[ICR]) != 0);
> }
>
If my memory is correct, though ICS is marked as read only in the spec,
we do can read it when I'm examining a real e1000 card.
Re: [Qemu-devel] [PATCH] e1000: make ICS write-only, Michael S. Tsirkin, 2013/01/09