[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH V4 2/4] HMP: add infrastructure for sub command |
Date: |
Thu, 10 Jan 2013 11:23:19 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Wenchao Xia <address@hidden> writes:
> This patch make parsing of hmp command aware of that it may
> have sub command. Also discard simple encapsulation function
> monitor_find_command() and qmp_find_cmd().
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> monitor.c | 31 +++++++++++++++++++++++--------
> 1 files changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index c7b3014..d49a362 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -130,6 +130,7 @@ typedef struct mon_cmd_t {
> MonitorCompletion *cb, void *opaque);
> } mhandler;
> int flags;
> + struct mon_cmd_t *sub_table;
> } mon_cmd_t;
>
> /* file descriptors passed via SCM_RIGHTS */
Forgot to mention: please explain in a comment how mhandler and
sub_table interact. Namely, if there are arguments, we use sub_table,
else mhandler.