Re: [Qemu-devel] [PATCH][v2] linux-user, alpha: l_type of fcntl() flock differs

[Laurent Vivier]

Le jeudi 10 janvier 2013 à 13:05 -0800, Richard Henderson a écrit :
> On 01/10/2013 12:42 PM, Laurent Vivier wrote:
> > +static const bitmask_transtbl flock_tbl[] = {
> > +    TRANSTBL_CONVERT(F_RDLCK),
> > +    TRANSTBL_CONVERT(F_WRLCK),
> > +    TRANSTBL_CONVERT(F_UNLCK),
> > +    TRANSTBL_CONVERT(F_EXLCK),
> > +    TRANSTBL_CONVERT(F_SHLCK),
> > +    { 0, 0, 0, 0 }
> > +};
> 
> Oh, I forgot to mention that you'll need to protect against the
> case of F_RDLCK == 0 && TARGET_F_RDLCK == 0.  The easiest way to
> handle this is place that entry last.

Look at the macro, I put all masks to -1, is it a mistake ?

Regards,
Laurent
-- 
"Just play. Have fun. Enjoy the game."
- Michael Jordan