[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/pc.c: Fix converting of iopor
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/pc.c: Fix converting of ioport_register* to MemoryRegion |
Date: |
Fri, 11 Jan 2013 10:13:57 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 09, 2013 at 06:10:22PM +0000, Julien Grall wrote:
> The commit 258711 introduced MemoryRegion to replace ioport_region*
> for ioport 80h and F0h.
> A MemoryRegion needs to have both read and write callback otherwise a segfault
> will occur when an access is made.
>
> The previous behaviour of this both ioport is to return 0xffffffffffffffff.
> So keep this behaviour.
>
> Reported-by: Adam Lackorzynski <address@hidden>
> Signed-off-by: Julien Grall <address@hidden>
> ---
> hw/pc.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan