qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to c


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp)
Date: Fri, 11 Jan 2013 11:37:42 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121116 Thunderbird/10.0.11

>> ## +# @ChardevFile:
> 
> Should you mention '@in: #optional' and '@out:' in any further
> detail?

Done.

> Hmm; here you document ChardevFile as a separate type, but you
> didn't document ChardevDummy in patch 4/10.

As the name says it is just a dummy passed when the backend in
question doesn't need any parameters.  Therefore it is empty.  Does it
really need its own documentation stanza?

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]